Announcement

Collapse
No announcement yet.

contributing patches

Collapse
X
  • Filter
  • Time
  • Show
Clear All
new posts

  • contributing patches

    How does one contribute patches? Should I simply make a pull request on GitHub?

  • #2
    Hello,

    Yes, pull requests are a good place to start, but please keep in mind and code additions require the development teams review. Depending on the task load of the moment, this may mean the pull request review is delayed.

    Thanks
    Zach
    World Wind Team
    https://github.com/NASAWorldWind

    Comment


    • #3
      Ok, so how do I get access to the Github repository to create a branch with my proposed change? I think that's required to make a pull request. I've made a local clone of the repository, made my change in a branch, etc., but it appears that I'm not authorized to make any changes on Github. That's fair - I understand that you wouldn't want it open. But it's unclear to me how to submit a patch.

      Comment


      • #4
        Pull requests or reporting issues require GitHub accounts. Create a GitHub account and fork (button available in the webpage UI) the WWJ repo. Make the changes to that repo (branch doesn't really matter unless it helps your own workflow) and then open a pull request. From the main page of your forked repository on GitHub, there should be a button on the right hand side directly above the listing of files labeled: "Pull Request". Clicking that will initiate the dialog to opening a pull request with the changes you've made.
        Zach
        World Wind Team
        https://github.com/NASAWorldWind

        Comment

        Working...
        X