method isFileOutOfDate in WWIO.java seems to have a bug

[gtvilela]

When trying to understand the Expiry_time property in WWJ, I found myself analyzing the isFileOutOfDate method.

When comparing the file date and the expiry time, I was expecting that the file is considered expired when its time is greater than the expiry time.

But the function is using file.lastModified() < expiryTime, so the answer to isFileOutOfDate is false when the file time is greater then expiry time.

If I don't misunderstand what is a "expired file" then the test should be file.lastModified() > expiryTime to correctly answer the method's question isFileOutOfDate.

Thanks

Gabriel Vilela

[gtvilela]

Hello,

I think I understood what's happening.

I assumed that the "expiry time" term was used to define if a file is still valid in these terms:

- If my file time is before expiry time, that's ok, the file is valid. In the other hand, if my file time is after the expiry time, the file is expired and so the file is not valid anymore.

It happens that the "expiry time" is used in WWJ as a last update time. So the interpretation is different in this case.

- A file is valid if it's time is after the last update time. If it's before, it means there is a new update and my current file is no longer valid.

That was the confusion. My interpretation of "expiry time" wasn't related with the "last update time". With that new interpretation the code works fine, although the nomenclature could induce to a misunderstanding.

Thanks

Gabriel Vilela