Refactor RenderableLayer?

zerobarrier · 01-15-2008, 02:51 PM

Not to sound harsh, but RenderableLayer is extremely not thread safe. Furthermore, the private Collection renderables is exposed via getRenderables(). Does anyone plan on refactoring RenderableLayer to use a concurrent collection class (much like IconLayer) or another acceptable method of thread safety? IMO, a CopyOnWriteArrayList would be the best implementation to use.

patmurris · 01-15-2008, 05:48 PM

From tag:

Quote:

We'll be cleaning up these kinds of thread-safety issue sometime soon, in conjunction with a major API and implementation review. This one's a pretty easy fix, and he's right that a copy-on-write collection is probably the best choice.

zerobarrier · 01-15-2008, 05:52 PM

Excellent, thanks Pat.

asantiago · 01-16-2008, 07:09 AM

I put an entry in JIRA some day ago about this issue

01-15-2008, 02:51 PM	#1
zerobarrier Developer Join Date: Dec 2007 Posts: 55	Refactor RenderableLayer? Not to sound harsh, but RenderableLayer is extremely not thread safe. Furthermore, the private Collection renderables is exposed via getRenderables(). Does anyone plan on refactoring RenderableLayer to use a concurrent collection class (much like IconLayer) or another acceptable method of thread safety? IMO, a CopyOnWriteArrayList would be the best implementation to use. Last edited by zerobarrier; 01-15-2008 at 05:51 PM.

01-16-2008, 07:09 AM	#4
asantiago WWJ aficionado Join Date: Aug 2007 Posts: 136	I put an entry in JIRA some day ago about this issue __________________ \|--------------------------------------- \| http://www.acuriousanimal.com/ \|--------------------------------------- \| http://theballoonproject.blogspot.com \|--------------------------------------- \| _ __ \| /_\| ( _ _/'_ _ \|( \|. __)(//)//(/(/() \| _/ \|---------------------------------------

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

01-15-2008, 05:52 PM	#3
zerobarrier Developer Join Date: Dec 2007 Posts: 55	Excellent, thanks Pat.

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)