View Full Version : WWDuplicateRequestException
peterdn1
02-21-2011, 05:36 PM
We frequently run WWJ from within eclipse. When the application is started WWDuplicateRequestException is thrown a number of times. Would it be possible to not to submit the duplicate request, or alternatively not throw the exception and return from the method.
Daemon Thread [Thread-17]
(Suspended (exception WWDuplicateRequestException))
ThreadPoolExecutor$Worker.run() line: not available
Thread.run() line: not available protected void beforeExecute(Thread thread, Runnable runnable)
...
if (ThreadedTaskService.this.activeTasks.co ntains(runnable))
{
String message = Logging.getMessage("ThreadedTaskService.CancellingDuplicateT ask", runnable);
Logging.logger().finer(message);
return;//NEW CODE
//OLD CODE: throw new WWDuplicateRequestException(message);
}
...
nlneilson
02-21-2011, 08:55 PM
There are several threads on duplicate requests, number of tries, time to next try, etc.
This is handled extremely well compared to how it was before.
The time required for a duplicate request is very small.
For things like this I just figure out to prevent the printing of the error.
peterdn1
02-21-2011, 10:27 PM
If this is expected behavior which I have no issue with, then I would recommend not thowing the exception and just returning from the method when a duplicate request is sent.
nlneilson
02-21-2011, 11:39 PM
For some reason they want the error printed.
What they have for reporting is FINE, FINER, ... but no OFF.
I don't know how that is used.
One thing was when offline there was a lot of printing.
I did not want to change a key or variable for that or expect a user to do it.
I have an app that can be run from a .bat or .bash file and what is printed can
be used to track down problems from a user or myself.
I don't want a lot of printing of messages that are not necessary.
To get rid of those re offline:
util/SessionCacheRetrievalPostProcessor.java
line #202 and #205 comment
add return null; to line #206
http://forum.worldwindcentral.com/showthread.php?t=22498
You are not having a problem of your app running are you?
Neil
peterdn1
02-22-2011, 04:45 PM
I am not having an issue running the application and the issue with debugging is a minor annoyance. It appears that duplicate requests are handled correctly(the second request discarded) and cause no issues. This seems like a reasonable approach,why throw the exception. Creating a stack trace is not free and throwing the exception adds no value?
nlneilson
02-22-2011, 06:16 PM
Creating a stack trace is not free and throwing the exception adds no value?
I agree!
As of the 2/27/2011 release the exception is no longer thrown. The log message is still generated, however, but only at log level FINER.
peterdn1
02-26-2011, 09:58 PM
Thank you.
nlneilson
02-26-2011, 10:41 PM
Thanks Tag!
Tansir1
03-01-2011, 07:56 PM
Thank you tag!
nlneilson
03-01-2011, 09:23 PM
The latest available from http://builds.worldwind.arc.nasa.gov/download.asp
is 2/26/2011.
When will a version be available that includes the exception/logging changes?
edit: In the last 2 weeks the SDK has gone from ~38 to ~50MB, will be interesting
to see what has been added.
Not many projects are updated, bug fixes, additions, etc. as much as WWJ.
Great project!
Randy Kim
03-01-2011, 11:12 PM
The daily builds have been restored. Sorry about the outage. I triggered a manual build so today's snapshot is there right now.
We made a change to Javadocs and it caused the build server to crash.
nlneilson
03-02-2011, 01:22 AM
Great. I will be heading out tonight for a ~week and am glad to have the latest to take with me.
Thanks Randy
Neil
vBulletin® v3.7.1, Copyright ©2000-2013, Jelsoft Enterprises Ltd.